Set CA cert authority value for aurora cluster #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areida
commented
Aug 13, 2024
…tudios/terraform-aws-ecs-service into areida/ca-cert-authority-update
…tudios/terraform-aws-ecs-service into areida/ca-cert-authority-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the best practice is here. I've set it to use the current default CA which is valid until 2061, but maybe there's a better way to make this optional or a better way to configure it for "latest". I set up the inputs so that the cluster and the instances get the same CA because I couldn't imagine a scenario where we want them to be different.
I'm not sure why the tfscan is flagging so much stuff that's unrelated to my changes. Does that need to be fixed or can it be ignored?